feat: enable storage service encrypted endpoint #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huynguyen-hl
requested review from
namhoang1604,
ldhyen99 and
ashleythedeveloper
Code Coverage Report
|
namhoang1604
previously approved these changes
Nov 12, 2024
ldhyen99
reviewed
Nov 12, 2024
ldhyen99
reviewed
Nov 12, 2024
ldhyen99
reviewed
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This PR enables the
mock-appto use the encrypted endpoint of the storage service. It also updates all process functions to utilize theconstructVerifyURLfunction, so theregisterLinkResolverfunction no longer handles URL construction logic, making the code clearer and easier to maintain. All related unit tests and documentation have been updated accordingly. Additionally, theresultPathsetting in the storage configuration ofapp-config.jsonhas been removed, as it is no longer needed.Related Tickets & Documents
https://github.com/gs-gs/fa-ag-trace/issues/694
https://github.com/gs-gs/fa-ag-trace/issues/695
Mobile & Desktop Screenshots/Recordings
(/v1/documents):Issue DPP:
(v1/credentials):Issue DPP:
Failed to decrypt the encrypted VC:
Failed to compare the hash in the verify URL with the VC hash:
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?